Restore legacy datelc, fix ConfigFile error path, and sanitize CSV author names #917
+29
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes small, safe corrections that improve stability and correctness without changing behavior or adding features:
datelcfile (cncfdm.py)src/tests/gitdm-tests.pyexpects adatelcfile for the-Dpath, but cncfdm only wrotedatelc.csv.datelc.csv(modern, with header) and legacydatelc(fixed‑width, no header) like the historicalgitdm.pydid.datelcwork again; no change to CSV output.ReadFileType()(ConfigFile.py)ConfigFile.croak, which referenced a function attribute that doesn’t exist; on malformed lines this would raise the wrong exception.croak()directly.email_encode; close CSV files after writing.--numstathandling.Verification
-Dflow now emits bothdatelc.csvanddatelc(legacy), matching expectations insrc/tests/gitdm-tests.py.Risk assessment
datelcfile (additive) and correctly sanitized author names in ChangeSets CSVs.How to test
python src/tests/gitdm-tests.py-Dpath:git --git-dir src/tests/testrepo log -p -M | ./gitdm -Ddatelcanddatelc.csvare created anddatelcmatchessrc/tests/expected-datelc.xpected by tests. No breaking changes.